Skip to content

Commit

Permalink
changes following tests
Browse files Browse the repository at this point in the history
  • Loading branch information
8naama committed Nov 26, 2024
1 parent 860269f commit be6216a
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 7 deletions.
2 changes: 1 addition & 1 deletion charts/logzio-apm-collector/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ dependencies:
maintainers:
- name: Naama Bendalak
email: [email protected]
appVersion: 0.110.0
appVersion: 0.113.0
8 changes: 4 additions & 4 deletions charts/logzio-apm-collector/templates/_config.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
{{- if .Values.spm.enabled }}
{{- $tracesConfig := deepCopy .Values.traceConfig }}
{{- $spmForwarderConfig := deepCopy .Values.spmForwarderConfig }}
{{- ($tracesConfig | merge $spmForwarderConfig | mustMergeOverwrite) | toYaml }}
{{- tpl (($tracesConfig | merge $spmForwarderConfig | mustMergeOverwrite) | toYaml) . }}
{{- else }}
{{- .Values.traceConfig | toYaml }}
{{- tpl (.Values.traceConfig | toYaml) . }}
{{- end}}
{{- end }}

Expand All @@ -51,8 +51,8 @@
{{- $mergedConfig := merge $spmConfig $serviceGraphConfig }}
{{- $_ := set (index $mergedConfig "service" "pipelines" "metrics/spm-logzio") "receivers" (concat (index $mergedConfig "service" "pipelines" "metrics/spm-logzio" "receivers") (index $serviceGraphConfig "service" "pipelines" "metrics/spm-logzio" "receivers" )) -}}
{{- $_ := set (index $mergedConfig "service" "pipelines" "traces") "exporters" (concat (index $mergedConfig "service" "pipelines" "traces" "exporters") (index $serviceGraphConfig "service" "pipelines" "traces" "exporters" )) -}}
{{- $mergedConfig | toYaml }}
{{- tpl ($mergedConfig | toYaml) . }}
{{- else }}
{{- .Values.spmConfig | toYaml }}
{{- tpl (.Values.spmConfig | toYaml) . }}
{{- end }}
{{- end }}
2 changes: 0 additions & 2 deletions charts/logzio-apm-collector/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ The APM service address
{{- printf "http://%s.%s.svc.cluster.local" $serviceName .Release.Namespace }}
{{- end }}


{{/*
Get secret value either from the global section (parent chart is running) or the default sub chart section
*/}}
Expand All @@ -162,7 +161,6 @@ Get secret value either from the global section (parent chart is running) or the
{{- end -}}
{{- end -}}


{{/* Helm hooks annotations for otel operator */}}
{{- define "apm-collector.otelOpAnnotations" -}}
helm.sh/hook: "post-install, post-upgrade"
Expand Down
8 changes: 8 additions & 0 deletions charts/logzio-apm-collector/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ otel-operator:
## Path to the CA cert.
# caFile: ""

# The OpenTelemetry Operator webhook service may not always be ready in time, causing an error.
# to retry, we set `failurePolicy` to `ignore`. To block the operation if it fails, set to `Fail`.
failurePolicy: Ignore

# Deploying the collector using the operator is not supported currently.
# The collector image is specified to meet operator subchart requirments.
manager:
Expand Down Expand Up @@ -290,6 +294,9 @@ spmConfig:
user-agent: "{{ .Chart.Name }}-{{ .Chart.Version }}-helm"
timeout: 30s # Time to wait per attempt to send data
add_metric_suffixes: false
extensions:
health_check:
endpoint: :13133
receivers:
otlp:
protocols:
Expand Down Expand Up @@ -359,6 +366,7 @@ spmConfig:
- telemetry.sdk.language
- telemetry.sdk.name
service:
extensions: [health_check]
pipelines:
traces:
receivers: [otlp]
Expand Down

0 comments on commit be6216a

Please sign in to comment.