Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSLSUBJECT broken again #143

Open
markwj opened this issue Apr 10, 2019 · 2 comments
Open

SSLSUBJECT broken again #143

markwj opened this issue Apr 10, 2019 · 2 comments

Comments

@markwj
Copy link

markwj commented Apr 10, 2019

Was using v5.0.9 for a while, and sslsubject worked well. But, since upgrading to latest (v6.0.2), sslsubject is broken again.

My configuration is:

input {
  tcp {
    port => <redacted>
    ssl_enable => true
    ssl_verify => true
    ssl_cert => <redacted>
    ssl_key => <redacted>
    ssl_certificate_authorities => <redacted>
    dns_reverse_lookup_enabled => false
    tcp_keep_alive => true
    codec => json_lines
    id => <redacted>
  }
}

A simple

output {
  stdout { codec => rubydebug { metadata => true } }
}

can show the issue clearly.

I did start some debugging, and find tcp.rb decode_buffer is being called with a nil socket from tcp/decoder_impl.rb decode. Not sure what has changed between v5.0.9 and v6.0.2.

I did a bisect. v5.0.10 works fine, but v5.2.0 is broken for this SSLSUBJECT. I see a large change there to convert to use netty ssl.

@rwaweber
Copy link
Contributor

rwaweber commented Jun 15, 2020

Seconding this, it appears as though it's still broken as of 6.0.6 with the same pipeline as above.

And by broken, I mean the sslsubject field does not appear in events. My guess, is the extraction here is no longer working.

@rwaweber
Copy link
Contributor

I put a PR together internally, needs to go through some internal review first but should be able to submit it in the next couple days hopefully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants