Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS "threads" setting was put in asciidoc in error. #51

Open
guyboertje opened this issue Feb 20, 2019 · 2 comments
Open

DOCS "threads" setting was put in asciidoc in error. #51

guyboertje opened this issue Feb 20, 2019 · 2 comments

Comments

@guyboertje
Copy link

I can't find any deprecated or previously valid threads setting in this plugin's history, ditto in the aws mixin.

@ph
Copy link
Contributor

ph commented Mar 4, 2019

@guyboertje @ep4sh Looking at the code, you are right @guyboertje there is nothing directly defined in the sqs.rb, but when the doc was generated it look up all the parents class for defined options. If you look at the class that the plugins inherits we are not inheriting from LogStash::Inputs::Base but instead we use LogStash::Inputs::Threadable from logstash like so:

class LogStash::Inputs::SQS < LogStash::Inputs::Threadable
include LogStash::PluginMixins::AwsConfig::V2

In the past there was a few plugins inheriting from that class, when the pipeline was created we were in fact creating multiple instance of the plugins based on the threads option. This was helping some plugins that had limits to fetch elements from external resources like the SQS inputs, the AWS' api limits the number of retrieved items to be 10.

With the changes to the pipeline and the parsing of the configuration I don't know if the core still respect that behavior.

@ep4sh
Copy link

ep4sh commented Mar 4, 2019

Okay, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants