From 2140c4e85ae2a3fbd1863c5f442e0e85be8f28e3 Mon Sep 17 00:00:00 2001 From: Stuart Johnson Date: Wed, 7 Feb 2024 14:05:46 +0000 Subject: [PATCH] slim down2 --- .github/workflows/docker-publish.yml | 86 +++++++++++++++++----------- Dockerfile | 1 - 2 files changed, 51 insertions(+), 36 deletions(-) diff --git a/.github/workflows/docker-publish.yml b/.github/workflows/docker-publish.yml index 27438d5..32e2daf 100644 --- a/.github/workflows/docker-publish.yml +++ b/.github/workflows/docker-publish.yml @@ -1,86 +1,102 @@ -name: Build and Sign Docker Images +name: Docker + +# This workflow uses actions that are not certified by GitHub. +# They are provided by a third-party and are governed by +# separate terms of service, privacy policy, and support +# documentation. on: push: branches: [ "main" ] + # Publish semver tags as releases. tags: [ 'v*.*.*' ] pull_request: branches: [ "main" ] env: + # Use docker.io for Docker Hub if empty REGISTRY: ghcr.io + # github.repository as / IMAGE_NAME: ${{ github.repository }} + jobs: - build-and-sign: + build: + runs-on: ubuntu-latest permissions: contents: read packages: write + # This is used to complete the identity challenge + # with sigstore/fulcio when running outside of PRs. id-token: write - strategy: - matrix: - board: - - milkv-duo - - milkv-duo-lite - - milkv-duo256m - - milkv-duo256m-lite - steps: - name: Checkout repository uses: actions/checkout@v3 + # Install the cosign tool except on PR + # https://github.com/sigstore/cosign-installer - name: Install cosign - uses: sigstore/cosign-installer@main + if: github.event_name != 'pull_request' + uses: sigstore/cosign-installer@6e04d228eb30da1757ee4e1dd75a0ec73a653e06 #v3.1.1 with: - cosign-release: 'v1.5.2' # Use the latest release or specify a version - + cosign-release: 'v2.1.1' + # Set up BuildKit Docker container builder to be able to build + # multi-platform images and export cache + # https://github.com/docker/setup-buildx-action - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v3.0.0 + uses: docker/setup-buildx-action@f95db51fddba0c2d1ec667646a06c2ce06100226 # v3.0.0 + # Login against a Docker registry except on PR + # https://github.com/docker/login-action - name: Log into registry ${{ env.REGISTRY }} if: github.event_name != 'pull_request' - uses: docker/login-action@v3.0.0 + uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0 with: registry: ${{ env.REGISTRY }} username: ${{ github.actor }} password: ${{ secrets.GITHUB_TOKEN }} + # Extract metadata (tags, labels) for Docker + # https://github.com/docker/metadata-action - name: Extract Docker metadata id: meta - uses: docker/metadata-action@v5.0.0 + uses: docker/metadata-action@96383f45573cb7f253c731d3b3ab81c87ef81934 # v5.0.0 with: - images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-${{ matrix.board }} + images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} flavor: | - latest=true - tags: | - type=ref,event=branch - type=ref,event=pr - type=semver,pattern={{version}} - type=sha + latest=${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} + + # Build and push Docker image with Buildx (don't push on PR) + # https://github.com/docker/build-push-action - name: Build and push Docker image - uses: docker/build-push-action@v5.0.0 + id: build-and-push + uses: docker/build-push-action@0565240e2d4ab88bba5387d719585280857ece09 # v5.0.0 with: context: . - file: ./Dockerfile push: ${{ github.event_name != 'pull_request' }} - tags: ${{ steps.meta.outputs.tags }} + tags: | + ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest + ${{ steps.meta.outputs.tags }} + labels: ${{ steps.meta.outputs.labels }} - build-args: BOARD=${{ matrix.board }} cache-from: type=gha cache-to: type=gha,mode=max + # Sign the resulting Docker image digest except on PRs. + # This will only write to the public Rekor transparency log when the Docker + # repository is public to avoid leaking data. If you would like to publish + # transparency data even for private images, pass --force to cosign below. + # https://github.com/sigstore/cosign - name: Sign the published Docker image if: ${{ github.event_name != 'pull_request' }} - run: | - TAGS="${{ steps.meta.outputs.tags }}" - IFS=',' read -ra TAG_ARRAY <<< "$TAGS" - for tag in "${TAG_ARRAY[@]}"; do - cosign sign ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-${{ matrix.board }}:$tag - done - continue-on-error: true env: - COSIGN_EXPERIMENTAL: "true" + # https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable + TAGS: ${{ steps.meta.outputs.tags }} + DIGEST: ${{ steps.build-and-push.outputs.digest }} + # This step uses the identity token to provision an ephemeral certificate + # against the sigstore community Fulcio instance. + run: echo "${TAGS}" | xargs -I {} cosign sign --yes {}@${DIGEST} \ No newline at end of file diff --git a/Dockerfile b/Dockerfile index 1fbba64..60605b2 100644 --- a/Dockerfile +++ b/Dockerfile @@ -49,7 +49,6 @@ RUN echo "set(CMAKE_CROSSCOMPILING TRUE)" >> $TOOLCHAIN_FILE RUN echo "set(CMAKE_C_COMPILER riscv64-unknown-linux-musl-gcc)" >> $TOOLCHAIN_FILE RUN echo "set(CMAKE_CXX_COMPILER riscv64-unknown-linux-musl-g++)" >> $TOOLCHAIN_FILE -#WORKDIR $MILKV_DUO_SDK #Default to a bash session. CMD bash \ No newline at end of file