Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp_turbinia_disk_copy_ts recipe "--create_analysis_vm" option #920

Open
jkppr opened this issue Oct 8, 2024 · 0 comments
Open

gcp_turbinia_disk_copy_ts recipe "--create_analysis_vm" option #920

jkppr opened this issue Oct 8, 2024 · 0 comments
Labels
bug recipe Ideas for new recipes

Comments

@jkppr
Copy link
Collaborator

jkppr commented Oct 8, 2024

The --create_analysis_vm option for the gcp_turbinia_disk_copy_ts recipe does not work as expected.

The recipe lists --create_analysis_vm as an option with default value True. So I would expect the command dftimewolf gcp_turbinia_disk_copy_ts <source_project> <df_project> --turbinia_zone europe-west2-b --incident_id turbinia-vm1investigation --disks <disk> --create_analysis_vm False to work. However, I get an dftimewolf: error: unrecognized arguments: False error. Using the option as a bool flag like this: dftimewolf gcp_turbinia_disk_copy_ts <source_project> <df_project> --turbinia_zone europe-west2-b --incident_id turbinia-vm1investigation --disks <disk> --create_analysis_vm does not raise any error but still creates a new analysis VM.

I think creating the analysis VM by default makes sense, but it would be good to have the option to disable this function.

@jkppr jkppr added bug recipe Ideas for new recipes labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug recipe Ideas for new recipes
Projects
None yet
Development

No branches or pull requests

1 participant