Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding out why islands are flagged #139

Open
ErikOsinga opened this issue Oct 5, 2020 · 7 comments
Open

Finding out why islands are flagged #139

ErikOsinga opened this issue Oct 5, 2020 · 7 comments

Comments

@ErikOsinga
Copy link

If I understand it correctly from the documentation, when fitting Gaussians to islands of emission, a flag value is being saved inside the fitting code. After fitting, I usually also get the message WARNING: All Gaussians were flagged for the following islands:

It would be a nice addition if on that list of flagged islands, the flag value or perhaps also the reason why they are being flagged is printed. As I understand it, there is no way to find the flag value after the fitting so the only way to find out why a source is being flagged is by changing the flagging parameters.

Thanks,
Erik

@darafferty
Copy link
Collaborator

That's a good idea -- I'll look into adding the flag value to that list. Currently, you can see the flag value with the show_fit task if you set ch0_flagged to True (see https://www.astron.nl/citt/pybdsf/show_fit.html#term-ch0-flagged) and then click on the Gaussian of interest.

@ErikOsinga
Copy link
Author

Thanks! I did try that, but in my case there is no Gaussian showing up to click on. For example, in the image below I am wondering why island 27 is flagged:

WhyFLAGGED

@darafferty
Copy link
Collaborator

Hmm, there must be a bug in show_fit, as it should indeed show the flagged Gaussian in the third panel. Thanks for reporting this -- I'll see if I can track it down...

@ErikOsinga
Copy link
Author

Thanks, if you need any additional information, please let me know.

@darafferty
Copy link
Collaborator

Strangely, I cannot reproduce the issue with show_fit not showing flagged Gaussians (they appear without problem for me). Do they show up for some islands but not others, or do they never show?

At any rate, I added the flag values to the output. Let me know if it doesn't work for you (you need rebuild with the current master to pick up the changes).

@ErikOsinga
Copy link
Author

They never show for me, but I might be using an old version of PYBDSF? (It's currently installed on machines that use python2 as default)

I tried to install the newest version from the master branch, but I am getting some errors related to a missing boost library... PYBDSF should work for python3 right?

Thanks.

@darafferty
Copy link
Collaborator

Yes, both Python 2 and 3 are supported. Boost issues are a common problem with PyBDSF installations, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants