From c98f2c0c9d2d904d04e1859613a6d2edda18bd0c Mon Sep 17 00:00:00 2001 From: Joaquin Matres <4514346+joamatab@users.noreply.github.com> Date: Tue, 30 Jul 2024 22:40:51 -0700 Subject: [PATCH 1/3] improve contribution guidelines --- docs/contribution.md | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/docs/contribution.md b/docs/contribution.md index 3cd4c97b9c..24fa030d67 100644 --- a/docs/contribution.md +++ b/docs/contribution.md @@ -31,26 +31,3 @@ The workflow is: ## Code of Conduct This project is a community effort, and everyone is welcome to contribute. Everyone within the community is expected to abide by our [code of conduct](https://github.com/gdsfactory/gdsfactory/blob/main/docs/code_of_conduct.md) - - -## Changelog - -We use `towncrier` for tracking changes and generating a changelog. -When making a pull request, we require that you add a towncrier entry along with the code changes. - -```bash -towncrier create . -``` - -Where change type can be `removed`, `deprecated`, `added`, `changed`, `fixed` - -Running this will create a file in the `.changelog.d` directory with a filename. - -Then before doing a new release we run - - -```bash -towncrier build --version= -``` - -Where `` is the expected version number of the release From 115f2364cfb3a184c9f0d3f39ba571631ebd7395 Mon Sep 17 00:00:00 2001 From: Niko Savola Date: Wed, 31 Jul 2024 13:29:13 +0000 Subject: [PATCH 2/3] Add actionlint to pre-commit hooks This will check GitHub Action workflows --- .pre-commit-config.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 559ce9fd73..91173bdd27 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -44,3 +44,8 @@ repos: # rev: v1.1.333 # hooks: # - id: pyright + + - repo: https://github.com/rhysd/actionlint + rev: v1.7.1 + hooks: + - id: actionlint From 34d7343f545934d075f7bccc42e51e717973fcff Mon Sep 17 00:00:00 2001 From: Daasein <68468076+Daasein@users.noreply.github.com> Date: Wed, 31 Jul 2024 12:03:22 -0500 Subject: [PATCH 3/3] Fix error raised when blank space is present in text within text_freetype.py --- gdsfactory/components/text_freetype.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdsfactory/components/text_freetype.py b/gdsfactory/components/text_freetype.py index ae57e92e86..4eb7b064ff 100644 --- a/gdsfactory/components/text_freetype.py +++ b/gdsfactory/components/text_freetype.py @@ -84,6 +84,9 @@ def text_freetype( char = Component() xoffset = 0 for letter in line: + if letter == " ": + xoffset += scale_factor * advance_x + continue letter_dev = Component() letter_template, advance_x, ascender = _get_glyph(font, letter) scale_factor = size / ascender