diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 559ce9fd73..91173bdd27 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -44,3 +44,8 @@ repos: # rev: v1.1.333 # hooks: # - id: pyright + + - repo: https://github.com/rhysd/actionlint + rev: v1.7.1 + hooks: + - id: actionlint diff --git a/docs/contribution.md b/docs/contribution.md index 3cd4c97b9c..24fa030d67 100644 --- a/docs/contribution.md +++ b/docs/contribution.md @@ -31,26 +31,3 @@ The workflow is: ## Code of Conduct This project is a community effort, and everyone is welcome to contribute. Everyone within the community is expected to abide by our [code of conduct](https://github.com/gdsfactory/gdsfactory/blob/main/docs/code_of_conduct.md) - - -## Changelog - -We use `towncrier` for tracking changes and generating a changelog. -When making a pull request, we require that you add a towncrier entry along with the code changes. - -```bash -towncrier create . -``` - -Where change type can be `removed`, `deprecated`, `added`, `changed`, `fixed` - -Running this will create a file in the `.changelog.d` directory with a filename. - -Then before doing a new release we run - - -```bash -towncrier build --version= -``` - -Where `` is the expected version number of the release diff --git a/gdsfactory/components/text_freetype.py b/gdsfactory/components/text_freetype.py index ae57e92e86..4eb7b064ff 100644 --- a/gdsfactory/components/text_freetype.py +++ b/gdsfactory/components/text_freetype.py @@ -84,6 +84,9 @@ def text_freetype( char = Component() xoffset = 0 for letter in line: + if letter == " ": + xoffset += scale_factor * advance_x + continue letter_dev = Component() letter_template, advance_x, ascender = _get_glyph(font, letter) scale_factor = size / ascender