fix(website): Set min width to 130px for columns without defined widths #3419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
changed the title
anna-parker
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks @theosanderson Much better than the current state! would be nice to make the togglebar a bit more visible when we add more columns as its easy to miss that there are more columns added on the right - but not blocking :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have lots of columns with defined min widths on PPX, when you add a new column it is given essentially zero width, and looks absurd.
Preview: https://theosanderson-patch-1.loculus.org/
Instead we should give a sensible minimum width, for now I'm going for 130px.