-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Trying out a new active-filter style #3397
Conversation
Definite improvement! It maybe now feels more salient than the form inputs, which may not be exactly what we want, but it looks really nice. |
I tried it (EDIT: also with some layout changes) -- See OP. But I can't tell, it might be too colorful 😅 I think it's time to go to bed lol |
Yeah, I think the Download form has always felt a bit of a distinct design from our main one - so personally I like the new approach for consistency! |
I really like this! Very cool. And thanks for the video and the before! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for the review/approval! I want to merge this into main on it's own though, to keep the history a bit cleaner (so I'm waiting for the other PR to get merged first) |
https://filterstyle.loculus.org
Idea is to make it less like an input, and maybe also use some color as accents on the modal. Also use display names for the fields instead of the URL params.
I'll see after the weekend if i still like it!
Screenshot
New 'selected sequences' filter
Screen.Recording.2024-12-07.at.01.01.10.mov
before
PR Checklist