Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Trying out a new active-filter style #3397

Merged
merged 8 commits into from
Dec 10, 2024
Merged

style: Trying out a new active-filter style #3397

merged 8 commits into from
Dec 10, 2024

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 6, 2024

https://filterstyle.loculus.org

Idea is to make it less like an input, and maybe also use some color as accents on the modal. Also use display names for the fields instead of the URL params.

I'll see after the weekend if i still like it!

Screenshot

image
New 'selected sequences' filter
Screen.Recording.2024-12-07.at.01.01.10.mov
before image

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fhennig fhennig changed the base branch from main to datausetermsbulkchange December 6, 2024 22:27
@theosanderson
Copy link
Member

Definite improvement! It maybe now feels more salient than the form inputs, which may not be exactly what we want, but it looks really nice.

@fhennig fhennig self-assigned this Dec 7, 2024
@fhennig fhennig added the preview Triggers a deployment to argocd label Dec 7, 2024
@fhennig
Copy link
Contributor Author

fhennig commented Dec 7, 2024

Thank you! Yes I agree regarding saliency. I think on here it's better:

image

Maybe more color in the controls is the way to go? I might go ahead and try that for the download page.

But of course toning down the colors is also an option, I'll experiment a bit

@fhennig
Copy link
Contributor Author

fhennig commented Dec 7, 2024

I tried it (EDIT: also with some layout changes) -- See OP.

But I can't tell, it might be too colorful 😅 I think it's time to go to bed lol

@theosanderson
Copy link
Member

Yeah, I think the Download form has always felt a bit of a distinct design from our main one - so personally I like the new approach for consistency!

@fhennig fhennig marked this pull request as ready for review December 9, 2024 08:24
@emmahodcroft
Copy link
Member

I really like this! Very cool. And thanks for the video and the before!

Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fhennig
Copy link
Contributor Author

fhennig commented Dec 10, 2024

Thanks for the review/approval!

I want to merge this into main on it's own though, to keep the history a bit cleaner (so I'm waiting for the other PR to get merged first)

Base automatically changed from datausetermsbulkchange to main December 10, 2024 15:35
@fhennig fhennig merged commit 32f1128 into main Dec 10, 2024
18 checks passed
@fhennig fhennig deleted the filterstyle branch December 10, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants