-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Upgrade to astro v5 #3376
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I think it isn't relevant for us? But can't really tell. Besides that I think we'd be good to go! |
Nice! Now we're ready for Astro 5 before it is even released! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice, so Astro 5 is actually out already!
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
311c7b0
to
a4e4078
Compare
Tests pass! Is everything looking good? I'm suspicious, but can't see anything that looks wrong. Maybe @corneliusroemer you want to have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
"@emotion/react": "^11.14.0", | ||
"@astrojs/mdx": "^4.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the deps are no longer sorted :)
preview URL: http://astro-v5.loculus.org
Summary
Using the guide: https://5-0-0-beta.docs.astro.build/en/guides/upgrade-to/v5/
Breaking changes to still check out: