Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade to astro v5 #3376

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore(deps): Upgrade to astro v5 #3376

merged 1 commit into from
Dec 11, 2024

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 5, 2024

@fhennig fhennig marked this pull request as draft December 5, 2024 08:30
@fhennig fhennig self-assigned this Dec 5, 2024
@fhennig fhennig added preview Triggers a deployment to argocd website Tasks related to the web application dependencies Pull requests that update a dependency file labels Dec 5, 2024
@fhennig

This comment was marked as outdated.

@fhennig

This comment was marked as outdated.

@fhennig
Copy link
Contributor Author

fhennig commented Dec 5, 2024

Re: https://5-0-0-beta.docs.astro.build/en/guides/upgrade-to/v5/#changed-actions-submitted-by-html-forms-no-longer-use-cookie-redirects

I think it isn't relevant for us? But can't really tell.

Besides that I think we'd be good to go!

@corneliusroemer
Copy link
Contributor

Nice! Now we're ready for Astro 5 before it is even released!

Copy link
Contributor

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, so Astro 5 is actually out already!

website/src/config.ts Outdated Show resolved Hide resolved
corneliusroemer

This comment was marked as outdated.

@fhennig

This comment was marked as outdated.

@fhennig

This comment was marked as outdated.

@fhennig

This comment was marked as outdated.

@fhennig

This comment was marked as outdated.

@fhennig fhennig force-pushed the astro-v5 branch 3 times, most recently from 311c7b0 to a4e4078 Compare December 10, 2024 16:06
@fhennig
Copy link
Contributor Author

fhennig commented Dec 10, 2024

Tests pass! Is everything looking good? I'm suspicious, but can't see anything that looks wrong. Maybe @corneliusroemer you want to have a look?

@fhennig fhennig marked this pull request as ready for review December 10, 2024 16:16
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fhennig fhennig merged commit e0dd8a8 into main Dec 11, 2024
19 checks passed
@fhennig fhennig deleted the astro-v5 branch December 11, 2024 07:29
"@emotion/react": "^11.14.0",
"@astrojs/mdx": "^4.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the deps are no longer sorted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file preview Triggers a deployment to argocd website Tasks related to the web application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants