Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Authentication site: reset_password.liquid page has incorrect alert warning #6

Open
greyskin opened this issue Jul 26, 2021 · 2 comments

Comments

@greyskin
Copy link

In the user authentication site (auth folder), on the reset_password.liquid page, lines 30-32 has the following code:

{% if auth_invalid_token %}
    <div class="alert alert-warning">Your token is valid</div>
{% endif %}

I believe the warning should say Your token is invalid.

@greyskin greyskin changed the title auth site reset_password page has incorrect alert warning User Authentication site reset_password.liquid page has incorrect alert warning Jul 27, 2021
@greyskin greyskin changed the title User Authentication site reset_password.liquid page has incorrect alert warning User Authentication site: reset_password.liquid page has incorrect alert warning Jul 27, 2021
@manuchap
Copy link

As a followup, I think that the word token doesn't mean jack to non-techies. It should be more user friendly like:
Security alert: You have exceeded the timeframe allowed to change your password. Please follow this link to renew your request. (or something along those lines)

@greyskin
Copy link
Author

@manuchap excellent point.

On that note, ony my site I'll be putting something along the lines of "the option to reset your password will be available for 2 hours" in the password_reset_instructions email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants