Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a starter shiny package template #129

Open
2 tasks
stephlocke opened this issue Mar 8, 2019 · 4 comments
Open
2 tasks

Make a starter shiny package template #129

stephlocke opened this issue Mar 8, 2019 · 4 comments

Comments

@stephlocke
Copy link
Member

stephlocke commented Mar 8, 2019

Let's enable people to get a shiny app package going quickly.

@maelle
Copy link
Contributor

maelle commented Mar 8, 2019

For reference here is the template used by golem https://github.com/ThinkR-open/golem/tree/master/inst/shinyexample Using that and renaming/filling stuff would be quite different from current functions starters has.

@stephlocke
Copy link
Member Author

stephlocke commented Mar 9, 2019

It covers a lot of the basic stuff we expect e.g. DESCRIPTION, R/ via: https://github.com/ThinkR-open/golem/blob/master/R/create_shiny_template.R

It then expects users to run numerous config / best practice things from usethis which I like starters to do by default including a bunch of stuff we can directly do because of our whoami config etc https://github.com/ThinkR-open/golem/blob/master/README.md#fill-the-description

Also, having a different foundation isn't something the package tries to avoid - create_package_project leverages usethis not create_basic_package for instance.

@maelle
Copy link
Contributor

maelle commented Mar 9, 2019

What I meant is that we probably do not want a template with a DESCRIPTION because only running devtools::use_descdiption() uses the default DESCRIPTION fields from .Renviron. In theory could the Shiny pkg creation use createPackageProject(), use the ThinkR template parts for R/ and inst/ and add a few dependencies?

@maelle
Copy link
Contributor

maelle commented Mar 9, 2019

Big pros IMO of making it depend on createPackageProject() is less work duplication, a good example for further such packages (for addins, RMarkdown templates...) and we could have someone fairly new contribute 😇

But maybe there are elements of createPackageProject() we do not want here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants