Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LazyCRS has incorrect OGC CRS WKT <geographic_crs_keyword> #438

Closed
vpipkt opened this issue Dec 20, 2019 · 6 comments
Closed

LazyCRS has incorrect OGC CRS WKT <geographic_crs_keyword> #438

vpipkt opened this issue Dec 20, 2019 · 6 comments

Comments

@vpipkt
Copy link
Member

vpipkt commented Dec 20, 2019

Pattern matching fails on the following legal values for OGC WKT:

Arguable if this should support <geodetic crs keyword> values GEODCRS | GEODETICCRS. I'm not sure if the downstream libraries do.

@vpipkt
Copy link
Member Author

vpipkt commented Dec 20, 2019

Hmm i may be mixing things up with different versions of the spec. Looking deeper into it now.

@vpipkt
Copy link
Member Author

vpipkt commented Dec 31, 2019

Some background based on more research.

RasterFrames CRS WKT parsing relies on the geotrellis proj4 module, which it seems is a port of a port...

The pyrasterframes dependencies currently resolve to a proj version 6 which has much more robust support for:

Propose for now clarifying the use of "WKT1" in the error messaging.

@vpipkt
Copy link
Member Author

vpipkt commented Dec 31, 2019

Probably should mark this as won't fix and perhaps defer to some other discussion about plans around LocationTech proj4j and GeoTrellis's proj4 module. It would be awesome to be able to use the 2015 or 2018 standards.

@pomadchin
Copy link
Member

pomadchin commented Dec 31, 2019

hey @vpipkt you're welcome to create PRs / open discussions in the proj4j locationtech repo: we're proj4 maintainers (Eugene & me)! We'll try to merge & release whatever is important for you ASAP.

Just co clarify things, geotrellis/proj4 is more a thin Scala wrapper / convenience layer between locationtech/proj4 and GeoTrellis, this about doc is a bit outdated, thanks for catching that. It no longer contains locationtech/proj4 files, GeoTrellis depends on locationtech/proj4(as a binary dep) since some 2.x version. More over locationtech/proj4 project is in fact the old geotrellis/proj4 library (we just moved this code into a separate repo during / a lil bit after the Bonn OSGEO CodeSprint in 2018).

@pomadchin
Copy link
Member

pomadchin commented Dec 31, 2019

Also both locationtech/proj4j#23 and locationtech/proj4j#49 are in our backlog, but I don't know when we'll have time to dive into them.

@vpipkt
Copy link
Member Author

vpipkt commented Jan 8, 2020

@pomadchin Sorry for the slow response. Very interesting. I think we can close this issue in favor of the related issues already cited here.

@vpipkt vpipkt closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants