Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: TLS support #1

Open
ysamlan opened this issue May 30, 2019 · 0 comments
Open

Feature: TLS support #1

ysamlan opened this issue May 30, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@ysamlan
Copy link
Contributor

ysamlan commented May 30, 2019

We're using it behind load balancers / gateways that terminate SSL, but for anyone who isn't, it'd be good to have a form of NewGroup like NewGroupWithTLS (or just some extra struct fields TLS folks can set after NewGroup) if they want the net/http.Server that gets spun up to support TLS directly.

I probably won't implement this myself since we aren't likely to need it at Localytics, but I don't think it'd be too much creep to add if someone wants to do the work (as long as the basic non-TLS case doesn't get any harder to use because of it).

(I think this is only needed for the main :8080 service, not the :6060 pprof debug server -- if that's exposed on the wider internet you have bigger problems than TLS).

@ysamlan ysamlan added the enhancement New feature or request label May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant