Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with Rails 5.2 #31

Open
GPif opened this issue Feb 25, 2019 · 4 comments
Open

Compatibility with Rails 5.2 #31

GPif opened this issue Feb 25, 2019 · 4 comments

Comments

@GPif
Copy link

GPif commented Feb 25, 2019

This gem is not compatible with rails 5.2 especailly because of the the disappearance of arel/visitors/bind_visitor. Is there any plan to update this gem?

I have made some quick fix on my side to have a workaround. Is it worst to make a PR?
@magichair
Copy link

Looks like there is a PR submitted - #26
We would also like to see this merged.

@brightbytes-dude
Copy link

Ditto - would love to see a fix merged.

@GS-Shahid GS-Shahid mentioned this issue May 17, 2022
Merged
@prostko
Copy link

prostko commented Jul 22, 2024

Can we please get this fix merged into a Rails 5 compatible version?

zokioki pushed a commit to doximity/odbc_adapter that referenced this issue Aug 30, 2024
@ACerka-Springbuk @zokioki
APP-3014 Update to use self.id instead of self[:id] as the later has …
f73407c 
…been deprecated (localytics#31)
@prostko
Copy link

prostko commented Dec 13, 2024

Bump. Can we please merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@magichair @GPif @brightbytes-dude @prostko