From ef52aee2711ff3d99dc72658b8dec4b209198340 Mon Sep 17 00:00:00 2001 From: Anand Bashyam Date: Tue, 4 Dec 2018 19:35:46 -0500 Subject: [PATCH] Fix Incorrect use of Shared namespace for module in Common project Fix name of the package in Makefile Fix name of the XML documentation to match module name Remove Objective c headers from nuget package --- .../LocalyticsSample/LocalyticsSample.cs | 2 +- .../LocalyticsXamarin.Common/Customer.cs | 3 +- .../Localytics.NuGet.nuproj | 45 ------------------- Makefile | 2 +- 4 files changed, 3 insertions(+), 49 deletions(-) diff --git a/LocalyticsXamarin/LocalyticsSample/LocalyticsSample.cs b/LocalyticsXamarin/LocalyticsSample/LocalyticsSample.cs index d1507dd..612a2c9 100644 --- a/LocalyticsXamarin/LocalyticsSample/LocalyticsSample.cs +++ b/LocalyticsXamarin/LocalyticsSample/LocalyticsSample.cs @@ -89,7 +89,7 @@ private void CommonSmokeTest() localytics.TagSearched("query", "type", 5, new Dictionary()); localytics.TagShared("name", "id", "type", "method", new Dictionary()); localytics.TagContentRated("name", "id", "type", 1, new Dictionary()); - LocalyticsXamarin.Shared.Customer customer = new LocalyticsXamarin.Shared.Customer("!234", "John", "Appleseed", "John Appleseed", "jappleseed@localytics.com"); + Customer customer = new Customer("!234", "John", "Appleseed", "John Appleseed", "jappleseed@localytics.com"); localytics.TagCustomerRegistered(customer, "method", new Dictionary()); diff --git a/LocalyticsXamarin/LocalyticsXamarin.Common/Customer.cs b/LocalyticsXamarin/LocalyticsXamarin.Common/Customer.cs index 9266bae..5f7aff1 100644 --- a/LocalyticsXamarin/LocalyticsXamarin.Common/Customer.cs +++ b/LocalyticsXamarin/LocalyticsXamarin.Common/Customer.cs @@ -1,8 +1,7 @@ using System; using LocalyticsXamarin.Common; -using LocalyticsXamarin.Shared; -namespace LocalyticsXamarin.Shared +namespace LocalyticsXamarin.Common { public class Customer : LocalyticsXamarin.Common.IXLCustomer { diff --git a/LocalyticsXamarin/LocalyticsXamarin.NuGet/Localytics.NuGet.nuproj b/LocalyticsXamarin/LocalyticsXamarin.NuGet/Localytics.NuGet.nuproj index 0966d15..adfce05 100644 --- a/LocalyticsXamarin/LocalyticsXamarin.NuGet/Localytics.NuGet.nuproj +++ b/LocalyticsXamarin/LocalyticsXamarin.NuGet/Localytics.NuGet.nuproj @@ -56,51 +56,6 @@ LocalyticsXamarinForms.cs - - Localytics.framework\Headers\LLCampaignBase.h - - - Localytics.framework\Headers\LLCustomer.h - - - Localytics.framework\Headers\LLGeofence.h - - - Localytics.framework\Headers\LLInAppCampaign.h - - - Localytics.framework\Headers\LLInAppConfiguration.h - - - Localytics.framework\Headers\LLInboxCampaign.h - - - Localytics.framework\Headers\LLInboxDetailViewController.h - - - Localytics.framework\Headers\LLInboxViewController.h - - - Localytics.framework\Headers\LLPlacesCampaign.h - - - Localytics.framework\Headers\LLRegion.h - - - Localytics.framework\Headers\LLWebViewCampaign.h - - - Localytics.framework\Headers\Localytics-Framework.h - - - Localytics.framework\Headers\Localytics.h - - - Localytics.framework\Headers\LocalyticsTypes.h - - - Localytics.framework\PrivateHeaders\LLPushToInboxCampaignJson.h - diff --git a/Makefile b/Makefile index 3a27650..b1f4d4f 100644 --- a/Makefile +++ b/Makefile @@ -36,5 +36,5 @@ ifneq ($(VER),) @cd LocalyticsXamarin/iOS && msbuild /t:Rebuild /p:Configuration=Release #Build NUget Package @cd LocalyticsXamarin/LocalyticsXamarin.NuGet && msbuild /t:Rebuild /p:Configuration=Release - @echo Publish LocalyticsXamarin/LocalyticsXamarin.NuGet/bin/Release/Localytics.$(VER).nupkg + @echo Publish LocalyticsXamarin/LocalyticsXamarin.NuGet/bin/Release/LocalyticsXamarin.$(VER).nupkg endif