Switch to group_sites

[ekes]

The new https://www.drupal.org/project/group_sites with https://www.drupal.org/project/group_context_domain in place of https://www.drupal.org/project/domain_group

[finnlewis]

CC @Adnan-cds @Boosmith @danchamp to share our thoughts on this.

[ekes]

Prodding it a bit, and looking at the code, it looks quite promising.

Custom code we'd have to update: the group creation, and association (it's just wiring in a, different, thirdpartysetting on the domain). Then all our code that looks up the group would need to be changed to use the context that group_sites uses. So far that's everything I've noticed.

[ekes]

This now exists in branches feature/group_sites of localgov_microsites, localgov_microsites_project, localgov_microsites_base and this localgov_microsites_group.

The branches also take an alternative approach for 'enabling' and 'disabling' modules per site.

First testing can be installing these clean. Tests all pass, and I've been creating sites and content during dev, but there will surely be things that haven't been spotted yet. The structure of the system is still exactly the same, so I've done a first punt at how to use the 'Admin mode' toggle that comes with group_sites, by fixing to be on permanently on the control site domain. Some code was move directly out of domain_group into localgov_microsites_group, some of is deprecated as it dupes group_sites, I figured I'd just do that in case anyone is using it; other stuff like the configuration plugin system remains and I've kept it call domain_group... as I can't see a naming clash happening and it's just easier for the upgrade path.

Note about the tests. They now use the subdomains group-0 group-1 group-2 so group-0.{base-domain} etc. need to be responded to in the test environment.

The upgrade path isn't quite there yet. It works, but you need to get the group_sites and group_context_domain enabled before switching to the branch, and you need to have the domain_group and domain_permissions modules there long enough to disable them after switching. I also got an error from localgov_search block, but that might be separate.