Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 #40

Open
millnut opened this issue Sep 27, 2024 · 8 comments
Open

PHP 8.4 #40

millnut opened this issue Sep 27, 2024 · 8 comments
Assignees

Comments

@millnut
Copy link
Member

millnut commented Sep 27, 2024

Add branch for PHP 8.4 and use PHP 8.4 RC1.

@stephen-cox how easy is it to create a PHP 8.4-RC1 image for this?

@stephen-cox stephen-cox self-assigned this Oct 4, 2024
@stephen-cox
Copy link
Member

The image just adds some stuff we need to run Drupal to the official PHP-Apache image (https://hub.docker.com/_/php). There's a php:8.4.0RC2-apache image so it should be able to use that as our base image.

@millnut
Copy link
Member Author

millnut commented Oct 18, 2024

Thanks @stephen-cox I'll take a look at this later as would be good to see how we are with the current 8.4-RC

@millnut
Copy link
Member Author

millnut commented Nov 5, 2024

Hi @stephen-cox I've created a php8.4 branch using the PHP 8.4-rc https://github.com/localgovdrupal/drupal-container/tree/php8.4. Unable to push to docker as will need to be granted permission

@stephen-cox
Copy link
Member

@millnut Do you have an account on Docker Hub? Happy to give you permission - we're using 2 out of a total if 3 users

@millnut
Copy link
Member Author

millnut commented Nov 16, 2024

@stephen-cox
Copy link
Member

@millnut You should have received an invite to the LocalGov Drupal Docker Hub organization.

@millnut
Copy link
Member Author

millnut commented Nov 19, 2024

Thanks @stephen-cox, received the invite. I'll look at the build readme and publish php 8.4 as a test later

@millnut
Copy link
Member Author

millnut commented Nov 20, 2024

Hi @stephen-cox I got it building following the readme, even though I'm logged into docker I get the error below when trying to push;

docker push localgovdrupal/apache-php:$branch
The push refers to repository [docker.io/localgovdrupal/apache-php]
cd1203d921f9: Preparing
b4c4c2d0d9f0: Preparing
d32317286086: Preparing
b4a19f537688: Preparing
3869350bd2ec: Preparing
f4a3ea2029d1: Waiting
08651c571524: Waiting
5f70bf18a086: Waiting
b0cd645ba28c: Waiting
d895ca65f269: Waiting
0b7ccd3c7715: Waiting
741bcbf7a7d9: Waiting
8d91b42b209b: Waiting
482c65a88d3f: Waiting
34f3dc51ef52: Waiting
ea153433f07d: Waiting
3205bacfeab1: Waiting
a5261f7bcc1c: Waiting
a79315097f6d: Waiting
4de06cadfbe9: Waiting
c3548211b826: Waiting
denied: requested access to the resource is denied

Looking at this I wonder if I need to be assign to a "maintainer" team rather than no team, so access is only read/write?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants