Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

android lint messages are not posted on PR #16

Open
RishabhTayal opened this issue Dec 28, 2018 · 6 comments
Open

android lint messages are not posted on PR #16

RishabhTayal opened this issue Dec 28, 2018 · 6 comments

Comments

@RishabhTayal
Copy link

My Dangerfile

  android_lint.gradle_task = 'checkstyle'
  android_lint.report_file = 'app/build/reports/checkstyle/checkstyle.xml'
  android_lint.lint(inline_mode: true)

The violations are detected by linting, but the messages are not posted to the github repo.

@jsouzapp
Copy link

I have the same problem.. Any solution for this case?

@mnmari
Copy link

mnmari commented Aug 18, 2022

I'm having a similar issue. All custom rules work locally when I run the Gradle lint task since they are added to the report file, but the messages are no longer being posted on pull requests nor being included on the report file when lint and danger are run on CI. Any thoughts on why that is no longer working? No changes were made on our Dangerfile regarding lint recently.

@barbosa
Copy link
Contributor

barbosa commented Aug 18, 2022

@mnmari was it posting before and now it's not? Or it never worked for you?

@mnmari
Copy link

mnmari commented Sep 6, 2022

@barbosa it was posting before, now it stopped posting for both new and old custom rules that Danger used to post in the past. 🤔

@mnmari
Copy link

mnmari commented Sep 15, 2022

Just a quick update. I initially thought it was a problem with the integration between lint and dangerfile. Turns out it was actually an issue with our CI, specifically on the script we use to run lint on PR's. It's all fixed now, thanks!

@cpaleop
Copy link

cpaleop commented Feb 9, 2023

I'm also facing this issue. I have verified everything.

  • No errors in Dangerfile
  • AGP Lint XML report with failures is being generated and it exists in the expected/defined folder
  • Token used to post PR messages is valid
  • danger-junit gem posts messages normally
  • using danger pr <pull_request_url> locally prints JUnit messages but no AGP Lint messages

It was working for a while but suddenly stopped. Current version: 0.0.11

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants