From 1a8f82e7a69a50e3514870cc42a1d14a06cb09a7 Mon Sep 17 00:00:00 2001
From: jpien13 <113210968+jpien13@users.noreply.github.com>
Date: Tue, 6 Aug 2024 17:47:47 -0400
Subject: [PATCH] [FIRRTL] Replaced 'replicate' to correctly named 'replace'
 flags (#7442)

Renamed and replaced shouldReplicateSequentialMemories to shouldReplaceSequentialMemories per issue #7384
---
 include/circt/Firtool/Firtool.h | 2 +-
 lib/Firtool/Firtool.cpp         | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/circt/Firtool/Firtool.h b/include/circt/Firtool/Firtool.h
index 9e6e7fbfb678..64ebefca783a 100644
--- a/include/circt/Firtool/Firtool.h
+++ b/include/circt/Firtool/Firtool.h
@@ -96,7 +96,7 @@ class FirtoolOptions {
     return allowAddingPortsOnPublic;
   }
   bool shouldConvertProbesToSignals() const { return probesToSignals; }
-  bool shouldReplicateSequentialMemories() const { return replSeqMem; }
+  bool shouldReplaceSequentialMemories() const { return replSeqMem; }
   bool shouldDisableOptimization() const { return disableOptimization; }
   bool shouldLowerMemories() const { return lowerMemories; }
   bool shouldDedup() const { return !noDedup; }
diff --git a/lib/Firtool/Firtool.cpp b/lib/Firtool/Firtool.cpp
index 0bfbfc13fb75..07d93548de3b 100644
--- a/lib/Firtool/Firtool.cpp
+++ b/lib/Firtool/Firtool.cpp
@@ -78,7 +78,7 @@ LogicalResult firtool::populateCHIRRTLToLowFIRRTL(mlir::PassManager &pm,
   pm.nest<firrtl::CircuitOp>().addPass(firrtl::createInferWidthsPass());
 
   pm.nest<firrtl::CircuitOp>().addPass(
-      firrtl::createMemToRegOfVecPass(opt.shouldReplicateSequentialMemories(),
+      firrtl::createMemToRegOfVecPass(opt.shouldReplaceSequentialMemories(),
                                       opt.shouldIgnoreReadEnableMemories()));
 
   pm.nest<firrtl::CircuitOp>().addPass(firrtl::createInferResetsPass());
@@ -161,7 +161,7 @@ LogicalResult firtool::populateCHIRRTLToLowFIRRTL(mlir::PassManager &pm,
     pm.nest<firrtl::CircuitOp>().nest<firrtl::FModuleOp>().addPass(
         firrtl::createInferReadWritePass());
 
-  if (opt.shouldReplicateSequentialMemories())
+  if (opt.shouldReplaceSequentialMemories())
     pm.nest<firrtl::CircuitOp>().addPass(firrtl::createLowerMemoryPass());
 
   pm.nest<firrtl::CircuitOp>().addPass(firrtl::createPrefixModulesPass());
@@ -176,7 +176,7 @@ LogicalResult firtool::populateCHIRRTLToLowFIRRTL(mlir::PassManager &pm,
   pm.addNestedPass<firrtl::CircuitOp>(firrtl::createAddSeqMemPortsPass());
 
   pm.addPass(firrtl::createCreateSiFiveMetadataPass(
-      opt.shouldReplicateSequentialMemories(),
+      opt.shouldReplaceSequentialMemories(),
       opt.getReplaceSequentialMemoriesFile()));
 
   pm.addNestedPass<firrtl::CircuitOp>(firrtl::createExtractInstancesPass());
@@ -303,7 +303,7 @@ LogicalResult firtool::populateHWToSV(mlir::PassManager &pm,
            FirtoolOptions::RandomKind::Mem),
        /*disableRegRandomization=*/
        !opt.isRandomEnabled(FirtoolOptions::RandomKind::Reg),
-       /*replSeqMem=*/opt.shouldReplicateSequentialMemories(),
+       /*replSeqMem=*/opt.shouldReplaceSequentialMemories(),
        /*readEnableMode=*/opt.shouldIgnoreReadEnableMemories()
            ? seq::ReadEnableMode::Ignore
            : seq::ReadEnableMode::Undefined,