This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
test: add integration test for instance-to-instance interaction #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into austin/integrations
AustinGreen
requested review from
0xrajath,
efecarranza,
dd0sxx and
mds1
as code owners
August 15, 2023 21:18
dd0sxx
reviewed
Aug 16, 2023
Co-authored-by: dd0sxx <[email protected]>
dd0sxx
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
0xrajath
approved these changes
Aug 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Before deployment, we want to test common workflows such as a Llama instance delegating responsibility to authorize additional strategy logics to another instance and the ability to instantly execute actions when the strategy permits.
Modifications:
createActionBySig
or we can deploy a custom contract for this purpose.Result:
A more robust test suite as we're nearing launch.