Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename LiveSubmitButton to LiveButton #24

Open
bcardarella opened this issue Oct 22, 2024 · 3 comments · May be fixed by #27
Open

Rename LiveSubmitButton to LiveButton #24

bcardarella opened this issue Oct 22, 2024 · 3 comments · May be fixed by #27
Assignees
@carson-katri

Comments

@bcardarella
Copy link
Contributor

Similar to HTML, we should support:

<LiveButton type="submit"> and <LiveButton type="reset">
@carson-katri
Copy link
Contributor

carson-katri commented Oct 23, 2024 •
edited
Loading

Would <LiveFormButton> work, so its more related to the library?

I assume most people would use the <.button> component anyways.

@bcardarella
Copy link
Contributor Author

I think I want to go with LiveButton

@bcardarella
Copy link
Contributor Author

Let's keep LiveSubmitButton but it will log a deprecation warning and delegate to LiveButton type="submit"

@carson-katri carson-katri linked a pull request Nov 5, 2024 that will close this issue
Rename LiveSubmitButton to LiveButton #27
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carson-katri carson-katri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename LiveSubmitButton to LiveButton liveview-native/liveview-native-live-form
2 participants
@bcardarella @carson-katri