Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg: Add demuxer options. #426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ffmpeg: Add demuxer options. #426

wants to merge 1 commit into from

Conversation

j0sh
Copy link
Collaborator

@j0sh j0sh commented Nov 18, 2024

This adds demuxer options as a complement to the existing encoder/muxer options which allows us to

  1. explicitly select the demuxer to use if probing doesn't return a good result, and
  2. configure the demuxer with additional options

This has come up a few times while looking at various things so it is good to have an API that is fully configurable out of the box.

This was partially implemented in #420 but this is more complete - it actually allows for demuxer selection and adds test cases.

Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j0sh Could you add a description to the PR to add the context ( 1) Why this change? 2) What is it changing from the "user" perspective? ). Thanks!

@j0sh
Copy link
Collaborator Author

j0sh commented Nov 20, 2024

@leszko

Updated the PR description. For more color as to "why" : I have been testing some flags to tune for latency but the gains are marginal so I am not sure we will keep them. eg, nobuffer allows us to drop up a few frames at the beginning to stay closer to the live edge, but this only really helps if you're playing back from the very beginning. if you start playback mid-stream then you're already starting at the live edge and it doesn't do anything.

BTW tests seem to be failing so I will hold off on merging this until I have some time to make CI green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants