Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runner): disable DEEPCACHE for lightning/turbo models #93

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

rickstaa
Copy link
Member

This commit ensures that people can not use the deepcache optimization with lightning and turbo models. As explained in #82 (comment) this optimization does not offer any speedup for these models while it does reduce image quality.

@rickstaa rickstaa force-pushed the disable_deep_cache_for_lightning_turbo_models branch from 884bafa to ba59122 Compare May 31, 2024 12:32
This commit ensures that people can not use the deepcache optimization
with lightning and turbo models. As explained in
#82 (comment)
this optimization does not offer any speedup for these models while it
does reduce image quality.
@rickstaa rickstaa force-pushed the disable_deep_cache_for_lightning_turbo_models branch from ba59122 to 45898e3 Compare May 31, 2024 12:33
Copy link
Collaborator

@eliteprox eliteprox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully with two small changes requested

runner/app/pipelines/util.py Outdated Show resolved Hide resolved
runner/app/pipelines/util.py Outdated Show resolved Hide resolved
This commit ensures that Lightning/Turbo model names with both the `-`
and `_` are matched when checking whether the orchestrator loaded a
Lightning/Turbo model.
@rickstaa rickstaa merged commit 24e480d into main Jun 4, 2024
1 check passed
@rickstaa rickstaa deleted the disable_deep_cache_for_lightning_turbo_models branch June 4, 2024 12:54
eliteprox pushed a commit to eliteprox/ai-worker that referenced this pull request Jun 9, 2024
* feat(runner): disable DEEPCACHE for lightning/turbo models

This commit ensures that people can not use the deepcache optimization
with lightning and turbo models. As explained in
livepeer#82 (comment)
this optimization does not offer any speedup for these models while it
does reduce image quality.

* fix: ensure correct lighthing/turbo matching

This commit ensures that Lightning/Turbo model names with both the `-`
and `_` are matched when checking whether the orchestrator loaded a
Lightning/Turbo model.
eliteprox pushed a commit to eliteprox/ai-worker that referenced this pull request Jul 26, 2024
* feat(runner): disable DEEPCACHE for lightning/turbo models

This commit ensures that people can not use the deepcache optimization
with lightning and turbo models. As explained in
livepeer#82 (comment)
this optimization does not offer any speedup for these models while it
does reduce image quality.

* fix: ensure correct lighthing/turbo matching

This commit ensures that Lightning/Turbo model names with both the `-`
and `_` are matched when checking whether the orchestrator loaded a
Lightning/Turbo model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants