Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose multimodal agent metrics #1080

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: expose multimodal agent metrics #1080

wants to merge 4 commits into from
+106 −6

Conversation

longcw
Copy link
Contributor

@longcw longcw commented Nov 13, 2024 •
edited by davidzhao
Loading

closes #1010

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 601ed19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
livekit-plugins-openai Patch
livekit-agents Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

theomonnom
theomonnom reviewed Nov 13, 2024
View reviewed changes
livekit-plugins/livekit-plugins-openai/livekit/plugins/openai/realtime/realtime_model.py Outdated
Comment on lines 72 to 75
created_timestamp: float
"""timestamp when the response was created"""
first_token_timestamp: float | None = None
"""timestamp when the first token was received"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep those states private

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to _created_timestamp and _first_token_timestamp.

@davidzhao davidzhao mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomonnom theomonnom theomonnom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose metrics from MultimodalAgent and RealtimeModel
2 participants
@longcw @theomonnom