add fallback when css masking is not supported #654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
As discussed in #652 , CSS masking is a relatively new feature and is not yet widely supported (baseline compatibility: "newly available").
This PR adds a fallback when it is not available by using the same svg data url as a background image instead, and makes the color darker or lighter by changing filter (e.g.
invert(0.8)
->invert(1)
).It does not use the
currentColor
like the CSS mask, however it uses shades of grey.Not ideal, but very usable.
This will only have effect when the CSS masking is not available.
The main code added:
Related Tickets & Documents
Fixes #652
Mobile & Desktop Screenshots/Recordings
If CSS masking doesn't work (before the fix):
Dark theme
Light theme
Share screen: light theme
Share screen: dark theme
Added tests?
Added to documentations?
@gigamaster , would you kindly review this at your convenience?