Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for invalid custom Upstream Server in DNS Interceptor #310

Open
neelanjan00 opened this issue Dec 15, 2022 · 0 comments
Open

Check for invalid custom Upstream Server in DNS Interceptor #310

neelanjan00 opened this issue Dec 15, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@neelanjan00
Copy link
Member

BUG REPORT

What happened: DNS interceptor tool supports using a custom upstream server. However, it doesn't validate if the upstream server is valid or not. Also, the checkValidUpstream function doesn't check for nil output from net.ParseIP function, hence returning incorrect boolean output from the parent function.

How to reproduce it (as minimally and precisely as possible): Use the DNS interceptor tool with incorrect upstream server env
@neelanjan00 neelanjan00 added the bug Something isn't working label Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neelanjan00