Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename env to EC2_INSTANCE_TAG #394

Merged

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Aug 7, 2024

Proposed changes:

Related issue litmuschaos/litmus#4807 (comment)

This PR fixes an issue where the ec2-stop-by-tag experiment fails to target the intended EC2 instance.

The ec2-stop-by-tag experiment encounters a TARGET_SELECTION_ERROR due to an incorrect retrieval of the EC2_INSTANCE_TAG environment variable.

Fault Summary:
TARGET_SELECTION_ERROR
{"errorCode":"TARGET_SELECTION_ERROR","phase":"PreChaos","reason":"failed to get the instance tag, invalid instance tag","target":"{EC2 Instance Tag: , Region: ap-northeast-2}"}

By correctly renaming the environment variable from INSTANCE_TAG to EC2_INSTANCE_TAG, we can accurately target the intended EC2 instance.

Types of changes:

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Special notes for your reviewer:

cc. @namkyu1999

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@Jonsy13
Copy link
Contributor

Jonsy13 commented Aug 12, 2024

Hi @jongwooo ,

Lint Charts check is failing. For fixing the same, Bump the version to next patch (3.9.1). And then run helm-docs also in same directory.

Ref contributing guide for more details - https://github.com/litmuschaos/litmus-helm/blob/master/CONTRIBUTING.md

@jongwooo jongwooo force-pushed the rename-env-to-ec2-instance-tag branch from 9c84af6 to 66099dc Compare August 12, 2024 07:07
@jongwooo jongwooo force-pushed the rename-env-to-ec2-instance-tag branch from 66099dc to 0f7308e Compare August 12, 2024 07:54
@Jonsy13
Copy link
Contributor

Jonsy13 commented Aug 14, 2024

Thanks @jongwooo , Just noticed that go runner image is also getting updated as part of this PR. Which means we first need to release go-runner. So now plan is lets wait till release of 3.10.0 which will have your fix. And then you can update your PR with 3.10.0 and then we can merge your PR.

@ispeakc0de ispeakc0de merged commit 24d858a into litmuschaos:master Aug 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants