Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

litmus-agent has APP_VERSION hard coded as 3.0.0-beta8 in template hook-pre-install-job.yaml #352

Closed
nwinstel-insight opened this issue Nov 21, 2023 · 6 comments

Comments

@nwinstel-insight
Copy link

nwinstel-insight commented Nov 21, 2023

Currently every variable in the litmus-agent hook-pre-install-job.yaml template file is variable except APP_VERSION.

APP_VERSION is hardcoded as 3.0.0-beta8.

Screenshot 2023-11-21 at 11 34 28 AM

Could this be updated to be a variable value we can override?

@nwinstel-insight nwinstel-insight changed the title litmus-agent has APP_VERSION hard coded as 3.0.0-beta8 in template litmus-agent has APP_VERSION hard coded as 3.0.0-beta8 in template hook-pre-install-job.yaml Nov 21, 2023
@Calvinaud
Copy link
Contributor

Calvinaud commented Dec 6, 2023

Hello,
It's was the goal of this PR: #330 to change this but still in progress. (and even a little stale)

@nwinstel-insight
Copy link
Author

@Calvinaud is there anything I can do to help get this through?

@dmcardoso
Copy link

Hi @Calvinaud are there any updates about that? We need this asap.

@Calvinaud
Copy link
Contributor

Hello,
The only thing still needed is the the approval on the PR.
The forked coded is here if you need it: https://github.com/Calvinaud/litmus-helm/tree/master
I will try to reping the maintener in the PR.

@Calvinaud
Copy link
Contributor

PR is merged so I suppose the issue should be considered as solved.

@Jonsy13
Copy link
Contributor

Jonsy13 commented Apr 8, 2024

Since @Calvinaud's changes have been merged already. Closing this issue, feel free to open this issue if the issue still persists. Thanks!!

@Jonsy13 Jonsy13 closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants