Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check against the accurate error type in tee ts-test #1539

Open
Kailai-Wang opened this issue Mar 28, 2023 · 1 comment
Open

Check against the accurate error type in tee ts-test #1539

Kailai-Wang opened this issue Mar 28, 2023 · 1 comment
Labels
D5-testing testing related tasks I2-medium should be completed within 10 working days Stale

Comments

@Kailai-Wang
Copy link
Collaborator

Context

Currently we widely use string.includes to test if a keyword matches. This is not ideal, for the error that has an explicit type in the pallet, we should check against the accurate type too.

String matching should only be considered for errors like StfErrors where the actual reason is hidden behind.

Medium prio


✔️ Please set appropriate labels and assignees if applicable.

@Kailai-Wang Kailai-Wang added I2-medium should be completed within 10 working days D3-chore tasks that need to be completed but don’t provide any additional features/functionality labels Mar 28, 2023
@Kailai-Wang Kailai-Wang added D5-testing testing related tasks and removed D3-chore tasks that need to be completed but don’t provide any additional features/functionality labels Apr 28, 2023
@github-actions
Copy link
Contributor

❗ This issue is stale because it has been open for 60 days with no activity.
Remove Stale label or update it, otherwise this issue will be closed in 7 days.
@litentry/parachain

@github-actions github-actions bot added the Stale label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D5-testing testing related tasks I2-medium should be completed within 10 working days Stale
Projects
None yet
Development

No branches or pull requests

1 participant