Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practice about licences in cloned pallets #1173

Open
Kailai-Wang opened this issue Jan 10, 2023 · 3 comments
Open

Best practice about licences in cloned pallets #1173

Kailai-Wang opened this issue Jan 10, 2023 · 3 comments
Labels
D4-documentation documentation creation/amendment I2-medium should be completed within 10 working days Stale

Comments

@Kailai-Wang
Copy link
Collaborator

Context

Not all pallets/code are initially developed by Litentry.

We have pallets that are either:

  • forked/cloned from other repos (e.g. teerex/teeracle/sidechain), or
  • working as a base, we modify and build on top of it (e.g. parachain-staking)

What's the best practice about the licence header here?

  • Keep the original one (what about our changes), or
  • Use Litentry's header but add README/doc to make it clear these are copied from othe projects

✔️ Please set appropriate labels and assignees if applicable.

@Kailai-Wang Kailai-Wang added D4-documentation documentation creation/amendment I2-medium should be completed within 10 working days labels Jan 10, 2023
@zTgx
Copy link
Contributor

zTgx commented Jan 11, 2023

depends on the type of license, integritee's under Apache License 2.0, as the license said, You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work.

so I think we should keep the original one, maybe we can add our license notice on top of it.

@github-actions
Copy link
Contributor

❗ This issue is stale because it has been open for 60 days with no activity.
Remove Stale label or update it, otherwise this issue will be closed in 7 days.
@litentry/parachain

@github-actions
Copy link
Contributor

❗ This issue is stale because it has been open for 60 days with no activity.
Remove Stale label or update it, otherwise this issue will be closed in 7 days.
@litentry/parachain

@github-actions github-actions bot added the Stale label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D4-documentation documentation creation/amendment I2-medium should be completed within 10 working days Stale
Projects
None yet
Development

No branches or pull requests

2 participants