Adding a bunch of features and refactoring the code to make it more reusable #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e reusable 1. Refactors logic into FastCollection which now takes an arbitrary model and view 2. Added public/private to things in a reasonable way 3. Adding the ability to have variable row heights 4. Making row height a parameter you can set 5. Removing a VStack which was at the base of ContentView that didn't do anything 6. Added a buffer parameter which allows you to load more views above and below the content window and means you're less likely to see white space when scrolling quickly
This is necessary because otherwise it's only updated when you scroll But you actually want to recalculate this every time body is called because the data in the view may have changed (due to insertion, deletion or completely new data) Performance wise, I wasn't able to find any significant difference. Before and after this change, visible rows is calculated approximately the same number of times. Also, I deleted the translatingY function as it wasn't used
Calculated the visibleRows once per layout Making sure that visibleRowBounds is calculated every layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commit:
This makes visibleRows a calculated property
This is necessary because otherwise it's only updated when you scroll
But you actually want to recalculate this every time body is called because the data in the view may have changed (due to insertion, deletion or completely new data)
Performance wise, I wasn't able to find any significant difference. Before and after this change, visible rows is calculated approximately the same number of times.
Also, I deleted the translatingY function as it wasn't used
Fixes #3
Another commit:
FIxes a bug where visibleBounds wasn't updated correctly
Makes a couple of performance improvements