New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make global delegations explicit #234

Open

oliverbarnes opened this issue Apr 5, 2021 · 1 comment

Member

oliverbarnes commented Apr 5, 2021

Currently it's implicit that, if a proposal_url is nil when creating a delegation, it means it's a global.

(Soon a nil voting method will also be part of that)

To somebody new to the codebase, and even to us, this is hard to tell.

We should refactor to make global delegations a deliberate, clear thing from the highest level and down.

Member Author

oliverbarnes commented Apr 5, 2021

Maybe we should look into the api interface itself as well (in which case, this would be more than refactor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment