Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow queries by delegator and delegate for a single delegation #114

Open
oliverbarnes opened this issue Aug 26, 2020 · 2 comments
Open

Comments

@oliverbarnes
Copy link
Member

Right now single delegations are only queriable by id.

@oliverbarnes
Copy link
Member Author

Explaining in more detail, what's meant here is being able to do queries like these:

query {
  delegations(delegatorEmail: ..., delegateEmail: ...) {
    ...
  }    
}

and

query {
  delegations(delegatorId: ..., delegateId: ...) {
    ...
  }    
}

@jinjagit
Copy link
Member

jinjagit commented Aug 26, 2020

TLDR: a particular delegator/delegate pair is not (will not be) sufficient to identify a unique delegation.

This query would return a list of matching delegations (or an empty list), since we are aiming for being able to make multiple different proposal-specific delegations which could be for same delegator-delegate pair. Hence, this query will return multiple delegations if multiple matches exist.

@oliverbarnes Are we OK with this type of query returning a list, or am I missing something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants