fix: network status in ForeignCluster resource #2783
+131
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @claudiolor. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
/build |
|
/build |
claudiolor
force-pushed
the
clo/fix-network-status
branch
from
10749dd
to
8b0a88f
Compare
cheina97
reviewed
Oct 23, 2024
pkg/liqo-controller-manager/core/foreigncluster-controller/status.go
Outdated
Show resolved
Hide resolved
cheina97
reviewed
Oct 23, 2024
pkg/liqo-controller-manager/core/foreigncluster-controller/status.go
Outdated
Show resolved
Hide resolved
cheina97
reviewed
Oct 23, 2024
pkg/liqo-controller-manager/core/foreigncluster-controller/status.go
Outdated
Show resolved
Hide resolved
cheina97
approved these changes
Oct 23, 2024
claudiolor
force-pushed
the
clo/fix-network-status
branch
from
992d74f
to
c16a934
Compare
|
/build |
fra98
reviewed
Oct 24, 2024
pkg/liqo-controller-manager/core/foreigncluster-controller/conditions.go
Outdated
Show resolved
Hide resolved
pkg/liqo-controller-manager/core/foreigncluster-controller/status.go
Outdated
Show resolved
Hide resolved
fra98
approved these changes
Oct 24, 2024
|
/build |
claudiolor
force-pushed
the
clo/fix-network-status
branch
from
0fb45f0
to
187cb4c
Compare
This patch fixes the network status in the ForeignCluster resource. Previously, when the connection or the configuration were missing no conditions were shown, so who looked at the ForeignCluster status could think that everything is correctly configured. Moreover, this patch makes the status check more robust, collecting all the errors first and only once we are sure that the module is enabled (there is at least a network resource present), it writes the errors in the status.
claudiolor
force-pushed
the
clo/fix-network-status
branch
from
187cb4c
to
f79d00b
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes the network status in the ForeignCluster resource. Previously, when the connection or the configuration were missing no conditions were shown, so who looked at the ForeignCluster status could think that everything is correctly configured.
Moreover, this patch makes the status check more robust, collecting all the errors first and only once we are sure that the module is enabled (there is at least a network resource present), it writes the errors in the status.