fix currency format for different locale #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpmgoncalves would you mind trying this out? Looks like you had this issue a while ago. @jenbennings and you if you happen to have aussie locale, I remember there being something weird |
|
Should I download the newest version to try it out @jorilallo? |
|
@jpmgoncalves just checked, it helps. Please merge it and build a new release.
|
|
@k06a, I don't have permissions to do that. |
|
@maksim-s can you review this PR? |
|
Almost one year passed and pr still not reviewed T_T |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locale currency was breaking by
numeraljsand regex.I tried to fix it using only native
Intl.NumberFormat.But they are open question about currency symbol position. In some localization, symbol staying in the end of digits and it break the app design.
fix #64 #50