Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thinkpad x12 detachable and Lenovo Precision Pen #541

Closed
johnledezma34 opened this issue Jan 4, 2023 · 8 comments
Closed

Thinkpad x12 detachable and Lenovo Precision Pen #541

johnledezma34 opened this issue Jan 4, 2023 · 8 comments

Comments

@johnledezma34
Copy link

Device name

... Thinkpad x12 detachable

Device model identifier

... Thinkpad x12 i3 version

udevadm info output

P: /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-1/i2c-WACF2200:00/0018:056A:525C.0005/input/input26/event14
M: event14
R: 14
U: input
D: c 13:78
N: input/event14
L: 0
S: input/by-path/pci-0000:00:15.1-platform-i2c_designware.1-event-mouse
E: DEVPATH=/devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-1/i2c-WACF2200:00/0018:056A:525C.0005/input/input26/event14
E: SUBSYSTEM=input
E: DEVNAME=/dev/input/event14
E: MAJOR=13
E: MINOR=78
E: USEC_INITIALIZED=6994419
E: ID_INPUT=1
E: ID_INPUT_TABLET=1
E: ID_INPUT_WIDTH_MM=259
E: ID_INPUT_HEIGHT_MM=172
E: ID_SERIAL=noserial
E: ID_PATH=pci-0000:00:15.1-platform-i2c_designware.1
E: ID_PATH_TAG=pci-0000_00_15_1-platform-i2c_designware_1
E: LIBINPUT_DEVICE_GROUP=18/56a/525c:i2c-WACF2200:00
E: DEVLINKS=/dev/input/by-path/pci-0000:00:15.1-platform-i2c_designware.1-event-mouse

@johnledezma34
Copy link
Author

johnledezma34 commented Jan 4, 2023

I can also provide my /bus/input txt file and my sysinfo.sh file. I don't really know if that is the udev data required. I just got the one referenced by the wacom HID 525c as a handler

@johnledezma34
Copy link
Author

Would I also need to add anything related to the pen itself? The pen is a lenovo precision pen, it has 3 buttons, 2 side buttons and a top clicker button.

@whot
Copy link
Member

whot commented Jan 5, 2023

Please have a look at the wiki here, thanks

@johnledezma34
Copy link
Author

Please have a look at the wiki here, thanks

I did thanks and I submitted the tarball. Hopefully something happens, although I saw that my device actually got submitted in sep 2022 and the issue remains open with no replies by devs 🙁

@whot
Copy link
Member

whot commented Jan 6, 2023

Can you link to the sysinfo issue please? That one doesn't need to be merged, as long as we have the link, that's good enough.

And you should be able to get a data file by taking a similar one and copying it + modifying it accordingly.

@johnledezma34
Copy link
Author

Can you link to the sysinfo issue please? That one doesn't need to be merged, as long as we have the link, that's good enough.

And you should be able to get a data file by taking a similar one and copying it + modifying it accordingly.

Here's mine.
linuxwacom/wacom-hid-descriptors#285

Here's another issue from sep 2022 with my hardware
linuxwacom/wacom-hid-descriptors#254

@whot
Copy link
Member

whot commented Jan 11, 2023

I'm gonna go out on a limb here and guess that you can take data/isdv4-5256.tablet and copy it, then change the few bits to update to your device. That should do the trick, unless your device is significantly different.

Unfortunately we're all overloaded, so submitting an MR for a tablet file is the most effective way to get this into libwacom.

@whot
Copy link
Member

whot commented Nov 27, 2023

Please see https://github.com/linuxwacom/libwacom/wiki/Adding-a-new-device

Closing this, it needs a pull request so we can merge the .tablet file but there's no need to keep the issue open. Please file the PR and we can get it in quickly.

@whot whot closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants