Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] GPG Keys #3

Closed
1 task done
modem7 opened this issue May 14, 2023 · 6 comments
Closed
1 task done

[FEAT] GPG Keys #3

modem7 opened this issue May 14, 2023 · 6 comments

Comments

@modem7
Copy link

modem7 commented May 14, 2023

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Github Desktop now offers the ability to use GPG keys to sign commits.

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
https://gist.github.com/xavierfoucrier/c156027fcc6ae23bcee1204199f177da

Would it be possible to have some way of easily importing GPG keys to be able to sign commits?

The request is purely "importing gpg keys to gpg in the container". The config can (and should) be done by the user.

E.g. A couple of ENV vars:

GPG=true/false
GPG_LOCATION=/config
GPG_KEY=mykey1,mykey2

This then could run something like gpg --import mykey1 gpg --import mykey2

Reason for change

Whilst it's doable in this image to implement the GPG key(s), the process is rather cumbersome.

  • Copy GPG key(s) to container
  • Import GPG key(s) to GPG
  • Update Github Config to reflect.

Proposed code change

No response

@modem7 modem7 added the enhancement New feature or request label May 14, 2023
@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@Roxedus
Copy link
Member

Roxedus commented May 14, 2023

Whilst it's doable in this image to implement the GPG key(s), the process is rather cumbersome.

Could you please expand on this, as Imagine the process is the same as on bare-metal.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@thelamer
Copy link
Member

I am still watching this, to facilitate any kind of automated ingestion of keys we need to understand the process that achieves this in the container and how to ingest the keys (IE should it be a mount, secret, env var? )

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI LinuxServer-CI closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2023
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Sep 16, 2023
@github-actions
Copy link

This issue is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

4 participants