Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Nginx log with real client IP #229

Open
1 task done
rochafabrizio opened this issue Oct 9, 2024 · 6 comments
Open
1 task done

[FEAT] Nginx log with real client IP #229

rochafabrizio opened this issue Oct 9, 2024 · 6 comments
Labels
enhancement New feature or request no-issue-activity

Comments

@rochafabrizio
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Bookstack container also provides a web server powered by nginx. However its access logs shows the ip address of the reverse proxies in front of it. It would be much better if there were a way to provide the trusted proxies, so nginx logs the client IP.

Reason for change

The way it is, nginx is logging the IP of reverse proxy in front of the docker, not the real client IP.

Proposed code change

No response

@rochafabrizio rochafabrizio added the enhancement New feature or request label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@j0nnymoe
Copy link
Member

j0nnymoe commented Oct 9, 2024

The container will already do this, the issue will be your host ke your proxy that is stripping that data. For example on Synology boxes you have to adjust iptables to enable it.

@rochafabrizio
Copy link
Author

Hi j0nnymoe, I noticed env var APP_PROXIES, don't know if thats what you mean, eitherway I'm setting it and it's only helping with Audit Log page. Please, let me know if there is any doc / article I can use. Thanks.

@j0nnymoe
Copy link
Member

j0nnymoe commented Oct 9, 2024

Without knowing your setup, I'm just making assumptions but this was the specific thing I was speaking about for Synology https://www.pedrolamas.com/2020/11/04/exposing-the-client-ips-to-docker-containers-on-synology-nas/

@kristiandg
Copy link

That worked for me. Hosting on Azure App Services, when I added the Env Variable "APP_PROXIES=*", I'm now getting client IPs in the audit log.

@LinuxServer-CI
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
Status: Issues
Development

No branches or pull requests

4 participants