Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] s6 readiness checking #83

Open
1 task done
Joker9944 opened this issue Aug 27, 2024 · 2 comments
Open
1 task done

[FEAT] s6 readiness checking #83

Joker9944 opened this issue Aug 27, 2024 · 2 comments
Labels
enhancement New feature or request no-issue-activity

Comments

@Joker9944
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Currently all s6 services report only up or down but not if they are ready or not. It would be nice to know if the services are ready to receive traffic.

Here is the documentation I found regarding readiness checking: https://skarnet.org/software/s6/notifywhenup.html

Reason for change

I'm writing a Kubernetes workload with an image based on this base image the service up status is great for startup and liveness probes but insufficient for readiness checks. Currently I'm checking like this /usr/bin/s6-svstat -o up /run/service/svc-kclient | grep --quiet true.

Proposed code change

I do know very little about kasm and s6 but am happy to volunteer my time. So I wanted to check first with the maintainers of this repo if a feature like this is feasible or even desirable.

@Joker9944 Joker9944 added the enhancement New feature or request label Aug 27, 2024
Copy link

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@LinuxServer-CI
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
Status: Issues
Development

No branches or pull requests

2 participants