Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md with Stratis information #455

Closed
briansmith0 opened this issue Jul 17, 2024 · 1 comment · Fixed by #456
Closed

Update README.md with Stratis information #455

briansmith0 opened this issue Jul 17, 2024 · 1 comment · Fixed by #456
Assignees
@vojtechtrefny

Comments

@briansmith0
Copy link

It appears that when using the role to configure Stratis you set the type: stratis, however the README.md file currently states that the only valid value for type is lvm. Is there anything else Stratis specific that also needs to be included/updated in the README.md file?
@vojtechtrefny vojtechtrefny self-assigned this Jul 17, 2024
vojtechtrefny added a commit to vojtechtrefny/storage that referenced this issue Jul 17, 2024
@vojtechtrefny
docs: Fix multiple small issues in README.md
9d00ba1 
Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments etc.

Resolves: linux-system-roles#455
@vojtechtrefny vojtechtrefny mentioned this issue Jul 17, 2024
Merged
@vojtechtrefny
Copy link
Collaborator

I think this should be the only place that needs to be updated. There are some news options for Stratis (for example encryption_clevis_pin) but I added those in the original Stratis PR. I found few more issues in the README and fixed them in #456

vojtechtrefny added a commit to vojtechtrefny/storage that referenced this issue Jul 17, 2024
@vojtechtrefny
docs: Fix multiple small issues in README.md
a937d76 
Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments etc.

Resolves: linux-system-roles#455
Resolves: linux-system-roles#428
Resolves: linux-system-roles#385
Related: linux-system-roles#437
vojtechtrefny added a commit to vojtechtrefny/storage that referenced this issue Jul 17, 2024
@vojtechtrefny
docs: Fix multiple small issues in README.md
a10aeba 
Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments etc.

Resolves: linux-system-roles#455
Resolves: linux-system-roles#428
Resolves: linux-system-roles#385
Related: linux-system-roles#437
vojtechtrefny added a commit to vojtechtrefny/storage that referenced this issue Jul 17, 2024
@vojtechtrefny
docs: Fix multiple small issues in README.md
5e93dab 
Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments,
partitioning support, formatting etc.

Resolves: linux-system-roles#455
Resolves: linux-system-roles#428
Resolves: linux-system-roles#385
Related: linux-system-roles#437
richm pushed a commit that referenced this issue Jul 17, 2024
@vojtechtrefny @richm
docs: Fix multiple small issues in README.md
06844b5 
Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments,
partitioning support, formatting etc.

Resolves: #455
Resolves: #428
Resolves: #385
Related: #437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vojtechtrefny vojtechtrefny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Fix multiple small issues in README.md vojtechtrefny/storage
2 participants
@vojtechtrefny @briansmith0