Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to add primary partition support #437

Open
Geertsky opened this issue Apr 29, 2024 · 2 comments
Open

Would like to add primary partition support #437

Geertsky opened this issue Apr 29, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Geertsky
Copy link

Hello,
I would like to extend the storage role so it could create primary partitions on a disk.
As blivet is being used by anaconda it is not clear to me why this is not already possible.
Could somebody explain to me why this is not possible?
Or better yet, explain to me how this actually already is possible! ;)

Pointers on where I would need to modify what in the storage r
/ole would also be greatly appreciated.

Thanks!

Regards,
Geert

Ps. I know the parted module, but blivet VS parted is an easy win for blivet to my opinion.

@richm
Copy link
Contributor

richm commented Jun 28, 2024

@vojtechtrefny @japokorn any ideas?

@vojtechtrefny
Copy link
Collaborator

The role can currently create a single partition on the entire disk, see #120 I think the main reason for this is we originally focused on the higher level storage (LVM, RAID...) and ignored everything "below" and nobody really asked for support for managing partitions (until now).

You can create "partition volume" with something like this

  roles:
    - name: linux-system-roles.storage
      storage_pools:
        - name: vda
          type: partition
          disks: vda
          volumes:
            - name: vda1
              type: partition
              fs_type: ext4

but BlivetPartitionVolume currently ignores the size passed to the volume and just creates the partition on the entire disk. So this is one thing that needs to be change, we also don't support any "advanced" options for partitions like creating extended partitions on MBR or resizing partitions etc.

But partitioning support is definitely something that can be added, as you said blivet can do it.

vojtechtrefny added a commit to vojtechtrefny/storage that referenced this issue Jul 17, 2024
Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments etc.

Resolves: linux-system-roles#455
Resolves: linux-system-roles#428
Resolves: linux-system-roles#385
Related: linux-system-roles#437
vojtechtrefny added a commit to vojtechtrefny/storage that referenced this issue Jul 17, 2024
Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments etc.

Resolves: linux-system-roles#455
Resolves: linux-system-roles#428
Resolves: linux-system-roles#385
Related: linux-system-roles#437
vojtechtrefny added a commit to vojtechtrefny/storage that referenced this issue Jul 17, 2024
Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments,
partitioning support, formatting etc.

Resolves: linux-system-roles#455
Resolves: linux-system-roles#428
Resolves: linux-system-roles#385
Related: linux-system-roles#437
richm pushed a commit that referenced this issue Jul 17, 2024
Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments,
partitioning support, formatting etc.

Resolves: #455
Resolves: #428
Resolves: #385
Related: #437
@vojtechtrefny vojtechtrefny self-assigned this Oct 31, 2024
@vojtechtrefny vojtechtrefny added the enhancement New feature or request label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants