Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate package checks for lvm2 #10

Closed
tabowling opened this issue Nov 24, 2018 · 2 comments
Closed

Duplicate package checks for lvm2 #10

tabowling opened this issue Nov 24, 2018 · 2 comments

Comments

@tabowling
Copy link
Contributor

tabowling commented Nov 24, 2018

Both lv and vg tasks are checking for lvm2 package to be installed. This results in duplicate checking which can slow down playbook execution.

[tbowling@tbowling storage]$ grep LVM2 */*
tasks/lv-default.yml:- name: Install LVM2 commands as needed
tasks/vg-default.yml:- name: Install LVM2 commmands as needed

It would be better to check for any packages one time at a global level, This would include any other toolings such as lvm2, parted, or others. A WHEN condition could be used so that you are only checking for those packages when that technology is requested. for example, if use_partitions is false, do not verify that package is installed.

@dwlehman
Copy link
Collaborator

#2 should help with this. If you get a chance to test, please provide feedback.

@vojtechtrefny
Copy link
Collaborator

I think this can be now closed, the dependencies are now handled by blivet in the main-blivet task which should run just once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants