Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add leading triple-hyphen to all github workflow files #214

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

natoscott
Copy link
Collaborator

Seems to resolve a github actions lint-style warning.

Seems to resolves a github actions lint-style warning.
@natoscott natoscott requested a review from richm as a code owner October 14, 2024 23:34
@spetrosi
Copy link
Contributor

spetrosi commented Oct 15, 2024

This will be overwritten the next time we run automation from https://github.com/linux-system-roles/.github/. We need to make ansible-lint ignore files in hidden folders. Or just ignore .github.

@richm
Copy link
Collaborator

richm commented Oct 15, 2024

This will be overwritten the next time we run automation from https://github.com/linux-system-roles/.github/. We need to make ansible-lint ignore files in hidden folders. Or just ignore .github.

the .github/ directory should already be ignored by ansible-lint: https://github.com/linux-system-roles/metrics/blob/main/.ansible-lint#L21

exclude_paths:
  - tests/roles/
  - .github/

@natoscott
Copy link
Collaborator Author

Yeah, I don't think it was ansible-lint complaining but something within the github workflow UI that was producing these warnings.

@natoscott
Copy link
Collaborator Author

This will be overwritten the next time we run automation from https://github.com/linux-system-roles/.github/. We need to make ansible-lint ignore files in hidden folders. Or just ignore .github.

Should this automation step produce new files with the expected yaml document start?

@natoscott natoscott merged commit c530e57 into linux-system-roles:main Oct 15, 2024
8 of 9 checks passed
@natoscott natoscott deleted the fix-yaml-warning branch October 15, 2024 23:11
@spetrosi
Copy link
Contributor

I updated it in linux-system-roles/.github#73, so that the next time we run automation it doesn't overwrite it here and fixes in other roles.

@natoscott
Copy link
Collaborator Author

@spetrosi awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants