Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add stas_data volume to fix last-known-config.pickle issue #251

Closed
wants to merge 1 commit into from

Conversation

glimchb
Copy link
Contributor

@glimchb glimchb commented Oct 11, 2022

Signed-off-by: Boris Glimcher [email protected]

Fixes #252

@glimchb
Copy link
Contributor Author

glimchb commented Oct 11, 2022

@martin-belanger @provandal FYI

privileged: true
network_mode: host

services:
stafd:
<<: *default-stas
environment:
RUNTIME_DIRECTORY: /run/stafd
RUNTIME_DIRECTORY: /run/stas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If both stafd and stacd use the same directory (/run/stas) they will overwrite each others files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they run in different containers, so no override here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they run in separate containers, but aren't they writing to the host's /run directory? If that's the case, they will both write to the same host directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only mount host /run/dbus and /etc/nvme to inside the containers
let me re-check about new stas_data I added...

@glimchb glimchb marked this pull request as draft October 12, 2022 14:04
@glimchb glimchb closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to save last known config: [Errno 2] No such file or directory: '/run/stafd/last-known-config.pickle'
2 participants