Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting the address in the JSON output #471

Open
igaw opened this issue Sep 14, 2022 · 1 comment
Open

Splitting the address in the JSON output #471

igaw opened this issue Sep 14, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@igaw
Copy link
Collaborator

igaw commented Sep 14, 2022

Should we split the 'address' for JSON?

Currently we have:

  +- nvme9 fc traddr=nn-0x201700a09890f5bf:pn-0x201900a09890f5bf,host_traddr=nn-0x200000109b579ef5:pn-0x100000109b579ef5 live 
 
          {
             "Name":"nvme9",
             "Transport":"fc",
             "Address":"traddr=nn-0x201700a09890f5bf:pn-0x201900a09890f5bf,host_traddr=nn-0x200000109b579ef5:pn-0x100000109b579ef5",
             "State":"live"
           }

I don't think we should change the shell output (again)? The nvme-cli 1.x version uses spaces as separator and not comma as by nvme-cli 2.x

But it would make sense to split the values into fields in the JSON output though? Something like

Address:  { 
  traddr = "...",
  host_traddr = "... ",
  trsvcid = "..."
}

But I assume this is something for 2.x of libnvme. But we might want to keep the current version and just add the spitted out values.

Thoughts?

@igaw igaw added the enhancement New feature or request label Sep 14, 2022
@igaw igaw added this to the 2.0 milestone Sep 14, 2022
@mwilck
Copy link
Contributor

mwilck commented Sep 14, 2022

I am for it, but obviously this is sort of an external API which is consumed by other tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants