Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Error when folder is selected in FzfxBuffers #738

Closed
savchenko opened this issue Jul 6, 2024 · 3 comments · Fixed by #739
Closed

Bug: Error when folder is selected in FzfxBuffers #738

savchenko opened this issue Jul 6, 2024 · 3 comments · Fixed by #739

Comments

@savchenko
Copy link
Contributor

Steps to reproduce

  1. Have NetRW open so that one of the buffers is a folder
  2. Call :FzfxBuffers and select the folder
  3. Observe the error below
E784: Cannot close last tab page                                                                                                                                                                                     
Error executing luv callback:                                                                                                                                                                                        
...al/share/nvim/lazy/fzfx.nvim/lua/fzfx/commons/fileio.lua:251: failed to read file "toolbox": "EISDIR: illegal operation on a directory"                                                                           
stack traceback:                                                                                                                                                                                                     
        [C]: in function 'error'                                                                                                                                                                                     
        ...al/share/nvim/lazy/fzfx.nvim/lua/fzfx/commons/fileio.lua:251: in function <...al/share/nvim/lazy/fzfx.nvim/lua/fzfx/commons/fileio.lua:249>

Potentially related to #734

@linrongbin16
Copy link
Owner

linrongbin16 commented Jul 8, 2024

hi @savchenko , I merged PR #739 to fix this issue. i.e. failed to read a directory.

But since I actually don't have a local environment to test it with netrw, so I'm not 100% confident it's been fixed. Please pull and try.

@savchenko
Copy link
Contributor Author

It actually doesn't list NetRW folders at all now. Perfect!

@linrongbin16
Copy link
Owner

It actually doesn't list NetRW folders at all now. Perfect!

I don't think I changed the providers, i.e. the NetRW list should remain the same results 🤣 .

Anyway, let's keep it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants