Add CalcResult<T> class #61
Conversation
Vovanda
commented
Jul 28, 2020
Vovanda
commented
- Provides the ability to use standard arithmetic operators
- Replaces the usual approach to throw an exception or return the null in case of an execution failure
Provides the ability to use standard arithmetic operators Replaces the usual approach to throw an exception or return the null in case of an execution failure
Add simple integration test Add tests on arithmetic operations and use operators
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public CalcResult<T> Add(T a) | ||
| { | ||
| if (IsValid) |
There was a problem hiding this comment.
Each if statement will add additional performance overhead. And conditional jump instruction is much slower than addition instruction.
| { | ||
| _value = Arithmetic<T>.Add(_value, a); | ||
| } | ||
| catch (Exception e) |
There was a problem hiding this comment.
What is the reason to add exceptions tracking here?
| } | ||
| } | ||
|
|
||
| public bool IsValid { get; set; } |
There was a problem hiding this comment.
Why do you want to store the validity state of the result?
|
I suggest you to look into the |
