Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorial method is not used anymore in the LinksPlatform, can we delete it? #59

Open
Konard opened this issue Jul 14, 2020 · 1 comment
Open

Factorial method is not used anymore in the LinksPlatform, can we delete it? #59

Konard opened this issue Jul 14, 2020 · 1 comment
Labels
question Further information is requested

Comments

@Konard
Copy link
Member

Konard commented Jul 14, 2020

Numbers/csharp/Platform.Numbers/Math.cs

Line 47 in d0b61ec

public static ulong Factorial(ulong n)

Since Catalan method uses precalculated values it does not depend on Factorial method anymore, therefore only the Catalan method is used in the LinksPlatform.
@Konard Konard added the question Further information is requested label Jul 14, 2020
@TwinkmrMask
Copy link
Member

Of course we can, but why and most importantly why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Konard @TwinkmrMask